From 37b5609ba2338e6d70f04e06641671831df38d70 Mon Sep 17 00:00:00 2001 From: granny Date: Tue, 12 Jan 2021 04:57:28 -0800 Subject: [PATCH] store most config checks in the yml file --- cogs/timings.py | 567 ++--------------------------------------- cogs/timings_check.yml | 296 ++++++++++++++++++++- 2 files changed, 320 insertions(+), 543 deletions(-) diff --git a/cogs/timings.py b/cogs/timings.py index dca0071..b234d16 100644 --- a/cogs/timings.py +++ b/cogs/timings.py @@ -77,14 +77,32 @@ class Timings(commands.Cog): unchecked = unchecked + 1 try: - online_mode = r["timingsMaster"]["onlinemode"] - bungeecord = r["timingsMaster"]["config"]["spigot"]["settings"]["bungeecord"] - velocity_online_mode = r["timingsMaster"]["config"]["paper"]["settings"]["velocity-support"]["online-mode"] - velocity_enabled = r["timingsMaster"]["config"]["paper"]["settings"]["velocity-support"]["enabled"] + if "config" in TIMINGS_CHECK: + server_properties = None + bukkit = None + spigot = None + paper = None + purpur = None + if "server.properties" in r["timingsMaster"]["config"]: + server_properties = r["timingsMaster"]["config"]["server.properties"] + if "bukkit" in r["timingsMaster"]["config"]: + bukkit = r["timingsMaster"]["config"]["bukkit"] + if "spigot" in r["timingsMaster"]["config"]: + spigot = r["timingsMaster"]["config"]["spigot"] + if "paper" in r["timingsMaster"]["config"]: + paper = r["timingsMaster"]["config"]["paper"] + if "purpur" in r["timingsMaster"]["config"]: + purpur = r["timingsMaster"]["config"]["purpur"] + + for config_name in TIMINGS_CHECK["config"]: + config = TIMINGS_CHECK["config"][config_name] + for option_name in config: + option = config[option_name] + for expression in option["expressions"]: + if not eval(expression): + continue + embed_var.add_field(**create_field({**{"name": option_name}, **option})) - if not online_mode and bungeecord == "false" and (velocity_online_mode == "false" or velocity_enabled == "false"): - embed_var.add_field(name="❌ online-mode", - value="Enable this in server.properties for security.") except KeyError: unchecked = unchecked + 1 @@ -222,72 +240,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - spigot_view_distance = r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["view-distance"] - view_distance = int(r["timingsMaster"]["config"]["server.properties"]["view-distance"]) - if view_distance >= 10 and spigot_view_distance == "default": - embed_var.add_field(name="❌ view-distance", - value="Decrease this from default (10) in spigot.yml. " - "Recommended: 3.") - except KeyError: - unchecked = unchecked + 1 - - try: - chunk_gc_period = int(r["timingsMaster"]["config"]["bukkit"]["chunk-gc"]["period-in-ticks"]) - if chunk_gc_period >= 600: - embed_var.add_field(name="❌ chunk-gc.period-in-ticks", - value="Decrease this in bukkit.yml.\nRecommended: 400.") - except KeyError: - unchecked = unchecked + 1 - - try: - ticks_per_monster_spawns = int(r["timingsMaster"]["config"]["bukkit"]["ticks-per"]["monster-spawns"]) - if ticks_per_monster_spawns == 1: - embed_var.add_field(name="❌ ticks-per.monster-spawns", - value="Increase this in bukkit.yml.\nRecommended: 4.") - except KeyError: - unchecked = unchecked + 1 - - try: - monsters_spawn_limit = int(r["timingsMaster"]["config"]["bukkit"]["spawn-limits"]["monsters"]) - if monsters_spawn_limit >= 70: - embed_var.add_field(name="❌ spawn-limits.monsters", - value="Decrease this in bukkit.yml.\nRecommended: 15.") - except KeyError: - unchecked = unchecked + 1 - - try: - water_ambient_spawn_limit = int(r["timingsMaster"]["config"]["bukkit"]["spawn-limits"]["water-ambient"]) - if water_ambient_spawn_limit >= 20: - embed_var.add_field(name="❌ spawn-limits.water-ambient", - value="Decrease this in bukkit.yml.\nRecommended: 2.") - except KeyError: - unchecked = unchecked + 1 - - try: - ambient_spawn_limit = int(r["timingsMaster"]["config"]["bukkit"]["spawn-limits"]["ambient"]) - if ambient_spawn_limit >= 15: - embed_var.add_field(name="❌ spawn-limits.ambient", - value="Decrease this in bukkit.yml.\nRecommended: 1.") - except KeyError: - unchecked = unchecked + 1 - - try: - animals_spawn_limit = int(r["timingsMaster"]["config"]["bukkit"]["spawn-limits"]["animals"]) - if animals_spawn_limit >= 10: - embed_var.add_field(name="❌ spawn-limits.animals", - value="Decrease this in bukkit.yml.\nRecommended: 3.") - except KeyError: - unchecked = unchecked + 1 - - try: - water_animals_spawn_limit = int(r["timingsMaster"]["config"]["bukkit"]["spawn-limits"]["water-animals"]) - if water_animals_spawn_limit >= 15: - embed_var.add_field(name="❌ spawn-limits.water-animals", - value="Decrease this in bukkit.yml.\nRecommended: 2.") - except KeyError: - unchecked = unchecked + 1 - try: mob_spawn_range = int(r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["mob-spawn-range"]) spigot_view_distance = r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["view-distance"] @@ -304,28 +256,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - animals_entity_activation_range = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "animals"]) - if animals_entity_activation_range >= 32: - embed_var.add_field(name="❌ entity-activation-range.animals", - value="Decrease this in spigot.yml. " - "Recommended: 6.") - except KeyError: - unchecked = unchecked + 1 - - try: - monsters_entity_activation_range = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "monsters"]) - if monsters_entity_activation_range >= 32: - embed_var.add_field(name="❌ entity-activation-range.monsters", - value="Decrease this in spigot.yml. " - "Recommended: 16.") - except KeyError: - unchecked = unchecked + 1 - try: raiders_entity_activation_range = int( r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ @@ -333,37 +263,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - misc_entity_activation_range = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"]["misc"]) - if misc_entity_activation_range >= 16: - embed_var.add_field(name="❌ entity-activation-range.misc", - value="Decrease this in spigot.yml. " - "Recommended: 4.") - except KeyError: - unchecked = unchecked + 1 - - try: - water_entity_activation_range = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"]["water"]) - if water_entity_activation_range >= 16: - embed_var.add_field(name="❌ entity-activation-range.water", - value="Decrease this in spigot.yml. " - "Recommended: 12.") - except KeyError: - unchecked = unchecked + 1 - - try: - villagers_entity_activation_range = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "villagers"]) - if villagers_entity_activation_range >= 32: - embed_var.add_field(name="❌ entity-activation-range.villagers", - value="Decrease this in spigot.yml. " - "Recommended: 16.") - except KeyError: - unchecked = unchecked + 1 - try: flying_monsters_entity_activation_range = int( r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ @@ -371,51 +270,13 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - tick_inactive_villagers = \ - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "tick-inactive-villagers"] - if tick_inactive_villagers == "true": - embed_var.add_field(name="❌ tick-inactive-villagers", - value="Disable this in spigot.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - nerf_spawner_mobs = r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["nerf-spawner-mobs"] - if nerf_spawner_mobs == "false": - embed_var.add_field(name="❌ nerf-spawner-mobs", - value="Enable this in spigot.yml.") - except KeyError: - unchecked = unchecked + 1 - try: wake_up_inactive_villagers_every = int( r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ "wake-up-inactive"]["villagers-every"]) except KeyError: unchecked = unchecked + 1 - try: - wake_up_inactive_villagers_for = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["villagers-for"]) - if wake_up_inactive_villagers_for >= 100: - embed_var.add_field(name="❌ wake-up-inactive.villagers-for", - value="Decrease this in spigot.yml. " - "Recommended: 20.") - except KeyError: - unchecked = unchecked + 1 - try: - wake_up_inactive_flying_monsters_for = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["flying-monsters-for"]) - if wake_up_inactive_flying_monsters_for >= 100: - embed_var.add_field(name="❌ wake-up-inactive.flying-monsters-for", - value="Decrease this in spigot.yml. " - "Recommended: 60.") - except KeyError: - unchecked = unchecked + 1 try: wake_up_inactive_animals_every = int( @@ -425,49 +286,7 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - wake_up_inactive_villagers_max_per_tick = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["villagers-max-per-tick"]) - if wake_up_inactive_villagers_max_per_tick >= 4: - embed_var.add_field(name="❌ wake-up-inactive.villagers-max-per-tick", - value="Decrease this in spigot.yml. " - "Recommended: 1.") - except KeyError: - unchecked = unchecked + 1 - - try: - wake_up_inactive_animals_for = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["animals-for"]) - if wake_up_inactive_animals_for >= 100: - embed_var.add_field(name="❌ wake-up-inactive.animals-for", - value="Decrease this in spigot.yml. " - "Recommended: 40.") - except KeyError: - unchecked = unchecked + 1 - try: - wake_up_inactive_monsters_max_per_tick = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["monsters-max-per-tick"]) - if wake_up_inactive_monsters_max_per_tick >= 8: - embed_var.add_field(name="❌ wake-up-inactive.monsters-max-per-tick", - value="Decrease this in spigot.yml. " - "Recommended: 4.") - except KeyError: - unchecked = unchecked + 1 - - try: - wake_up_inactive_flying_monsters_max_per_tick = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["flying-monsters-max-per-tick"]) - if wake_up_inactive_flying_monsters_max_per_tick >= 8: - embed_var.add_field(name="❌ wake-up-inactive.flying-monsters-max-per-tick", - value="Decrease this in spigot.yml. " - "Recommended: 1.") - except KeyError: - unchecked = unchecked + 1 try: wake_up_inactive_flying_monsters_every = int( @@ -483,236 +302,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - wake_up_inactive_animals_max_per_tick = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["animals-max-per-tick"]) - if wake_up_inactive_animals_max_per_tick >= 4: - embed_var.add_field(name="❌ wake-up-inactive.animals-max-per-tick", - value="Decrease this in spigot.yml. " - "Recommended: 2.") - except KeyError: - unchecked = unchecked + 1 - - try: - wake_up_inactive_monsters_for = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["entity-activation-range"][ - "wake-up-inactive"]["monsters-for"]) - if wake_up_inactive_monsters_for >= 100: - embed_var.add_field(name="❌ wake-up-inactive.monsters-for", - value="Decrease this in spigot.yml. " - "Recommended: 60.") - except KeyError: - unchecked = unchecked + 1 - - try: - arrow_despawn_rate = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["arrow-despawn-rate"]) - if arrow_despawn_rate >= 1200: - embed_var.add_field(name="❌ arrow-despawn-rate", - value="Decrease this in spigot.yml. " - "Recommended: 300.") - except KeyError: - unchecked = unchecked + 1 - - try: - item_merge_radius = float( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["merge-radius"]["item"]) - if item_merge_radius <= 2.5: - embed_var.add_field(name="❌ merge-radius.item", - value="Increase this in spigot.yml. " - "Recommended: 4.0.") - except KeyError: - unchecked = unchecked + 1 - - try: - exp_merge_radius = float( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["merge-radius"]["exp"]) - if exp_merge_radius <= 3.0: - embed_var.add_field(name="❌ merge-radius.exp", - value="Increase this in spigot.yml. " - "Recommended: 6.0.") - except KeyError: - unchecked = unchecked + 1 - - try: - max_entity_collisions = int( - r["timingsMaster"]["config"]["spigot"]["world-settings"]["default"]["max-entity-collisions"]) - if max_entity_collisions >= 8: - embed_var.add_field(name="❌ max-entity-collisions", - value="Decrease this in spigot.yml. " - "Recommended: 2.") - except KeyError: - unchecked = unchecked + 1 - - try: - max_auto_save_chunks_per_tick = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["max-auto-save-chunks-per-tick"]) - if max_auto_save_chunks_per_tick >= 24: - embed_var.add_field(name="❌ max-auto-save-chunks-per-tick", - value="Decrease this in paper.yml. " - "Recommended: 6.") - except KeyError: - unchecked = unchecked + 1 - - try: - optimize_explosions = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "optimize-explosions"] - if optimize_explosions == "false": - embed_var.add_field(name="❌ optimize-explosions", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - mob_spawner_tick_rate = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["mob-spawner-tick-rate"]) - if mob_spawner_tick_rate == 1: - embed_var.add_field(name="❌ mob-spawner-tick-rate", - value="Increase this in paper.yml. " - "Recommended: 2.") - except KeyError: - unchecked = unchecked + 1 - - try: - disable_chest_cat_detection = \ - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["game-mechanics"][ - "disable-chest-cat-detection"] - if disable_chest_cat_detection == "false": - embed_var.add_field(name="❌ disable-chest-cat-detection", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - container_update_tick_rate = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["container-update-tick-rate"]) - if container_update_tick_rate == "false": - embed_var.add_field(name="❌ container-update-tick-rate", - value="Increase this in paper.yml. " - "Recommended: 3.") - except KeyError: - unchecked = unchecked + 1 - - try: - grass_spread_tick_rate = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["grass-spread-tick-rate"]) - if grass_spread_tick_rate == 1: - embed_var.add_field(name="❌ grass-spread-tick-rate", - value="Increase this in paper.yml. " - "Recommended: 4") - except KeyError: - unchecked = unchecked + 1 - - try: - soft_despawn_range = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["despawn-ranges"]["soft"]) - if soft_despawn_range >= 32: - embed_var.add_field(name="❌ despawn-ranges.soft", - value="Decrease this in paper.yml. " - "Recommended: 28") - except KeyError: - unchecked = unchecked + 1 - - try: - hard_despawn_range = int(r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["despawn-ranges"]["soft"]) - if hard_despawn_range >= 128: - embed_var.add_field(name="❌ despawn-ranges.hard", - value="Decrease this in paper.yml. " - "Recommended: 48") - except KeyError: - unchecked = unchecked + 1 - - try: - hopper_disable_move_event = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["hopper"][ - "disable-move-event"] - if hopper_disable_move_event == "false": - embed_var.add_field(name="❌ hopper.disable-move-event", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - non_player_arrow_despawn_rate = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["non-player-arrow-despawn-rate"]) - if non_player_arrow_despawn_rate == -1: - embed_var.add_field(name="❌ non-player-arrow-despawn-rate", - value="Set a value in paper.yml. " - "Recommended: 60") - except KeyError: - unchecked = unchecked + 1 - - try: - creative_arrow_despawn_rate = int( - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["creative-arrow-despawn-rate"]) - if creative_arrow_despawn_rate == -1: - embed_var.add_field(name="❌ creative-arrow-despawn-rate", - value="Set a value in paper.yml. " - "Recommended: 60") - except KeyError: - unchecked = unchecked + 1 - - try: - prevent_moving_into_unloaded_chunks = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "prevent-moving-into-unloaded-chunks"] - if prevent_moving_into_unloaded_chunks == "false": - embed_var.add_field(name="❌ prevent-moving-into-unloaded-chunks", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - eigencraft_redstone = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "use-faster-eigencraft-redstone"] - if eigencraft_redstone == "false": - embed_var.add_field(name="❌ use-faster-eigencraft-redstone", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - fix_climbing_bypass_gamerule = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["fix-climbing-bypassing-cramming-rule"] - if fix_climbing_bypass_gamerule == "false": - embed_var.add_field(name="❌ fix-climbing-bypassing-cramming-rule", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - armor_stands_do_collision_entity_lookups = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["armor-stands-do-collision-entity-lookups"] - if armor_stands_do_collision_entity_lookups == "true": - embed_var.add_field(name="❌ armor-stands-do-collision-entity-lookups", - value="Disable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - plugins = r["timingsMaster"]["plugins"] - armor_stands_tick = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["armor-stands-tick"] - if armor_stands_tick == "true" and "PetBlocks" not in plugins and "BlockBalls" not in plugins and "ArmorStandTools" not in plugins: - embed_var.add_field(name="❌ armor-stands-tick", - value="Disable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - per_player_mob_spawns = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "per-player-mob-spawns"] - if per_player_mob_spawns == "false": - embed_var.add_field(name="❌ per-player-mob-spawns", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - alt_item_despawn_rate_enabled = \ - r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["alt-item-despawn-rate"]["enabled"] - if alt_item_despawn_rate_enabled == "false": - embed_var.add_field(name="❌ alt-item-despawn-rate.enabled", - value="Enable this in paper.yml.") - except KeyError: - unchecked = unchecked + 1 - try: no_tick_view_distance = int( r["timingsMaster"]["config"]["paper"]["world-settings"]["default"]["viewdistances"][ @@ -733,24 +322,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - enable_treasure_maps = r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "enable-treasure-maps"] - if enable_treasure_maps == "true": - embed_var.add_field(name="❌ enable-treasure-maps", - value="Disable this in paper.yml. Why? Generating treasure maps is extremely expensive and can hang a server if the structure it's trying to locate is really far away.") - except KeyError: - unchecked = unchecked + 1 - - try: - projectile_load_save = int(r["timingsMaster"]["config"]["paper"]["world-settings"]["default"][ - "projectile-load-save-per-chunk-limit"]) - if projectile_load_save == -1: - embed_var.add_field(name="❌ projectile-load-save-per-chunk-limit", - value="Set a value in paper.yml. Recommended: 8.") - except KeyError: - unchecked = unchecked + 1 - try: use_alternate_keepalive = r["timingsMaster"]["config"]["purpur"]["settings"]["use-alternate-keepalive"] plugins = r["timingsMaster"]["plugins"] @@ -763,94 +334,6 @@ class Timings(commands.Cog): except KeyError: unchecked = unchecked + 1 - try: - dont_send_useless_entity_packets = r["timingsMaster"]["config"]["purpur"]["settings"][ - "dont-send-useless-entity-packets"] - if dont_send_useless_entity_packets == "false": - embed_var.add_field(name="❌ dont-send-useless-entity-packets", - value="Enable this in purpur.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - disable_treasure_searching = \ - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["dolphin"][ - "disable-treasure-searching"] - if disable_treasure_searching == "false": - embed_var.add_field(name="❌ dolphin.disable-treasure-searching", - value="Enable this in purpur.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - brain_ticks = int( - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["villager"][ - "brain-ticks"]) - if brain_ticks == 1: - embed_var.add_field(name="❌ villager.brain-ticks", - value="Increase this in purpur.yml. " - "Recommended: 4.") - except KeyError: - unchecked = unchecked + 1 - - try: - iron_golem_radius = int( - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["villager"][ - "spawn-iron-golem"]["radius"]) - if iron_golem_radius == 0: - embed_var.add_field(name="❌ spawn-iron-golem.radius", - value="Set a value in purpur.yml. " - "Recommended: 32.") - except KeyError: - unchecked = unchecked + 1 - - try: - iron_golem_limit = int( - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["villager"][ - "spawn-iron-golem"]["limit"]) - if iron_golem_limit == 0: - embed_var.add_field(name="❌ spawn-iron-golem.limit", - value="Set a value in purpur.yml. " - "Recommended: 5.") - except KeyError: - unchecked = unchecked + 1 - - try: - aggressive_towards_villager_when_lagging = \ - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["zombie"][ - "aggressive-towards-villager-when-lagging"] - if aggressive_towards_villager_when_lagging == "true": - embed_var.add_field(name="❌ zombie.aggresive-towards-villager-when-lagging", - value="Disable this in purpur.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - entities_can_use_portals = \ - r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["gameplay-mechanics"][ - "entities-can-use-portals"] - if entities_can_use_portals == "true": - embed_var.add_field(name="❌ entities-can-use-portals", - value="Disable this in purpur.yml to prevent players from creating chunk anchors.") - except KeyError: - unchecked = unchecked + 1 - - try: - lobotomize_enabled = r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["mobs"]["villager"][ - "lobotomize"]["enabled"] - if lobotomize_enabled == "false": - embed_var.add_field(name="❌ villager.lobotomize.enabled", - value="Enable this in purpur.yml.") - except KeyError: - unchecked = unchecked + 1 - - try: - teleport_if_outside_border = r["timingsMaster"]["config"]["purpur"]["world-settings"]["default"]["gameplay-mechanics"]["player"]["teleport-if-outside-border"] - if teleport_if_outside_border == "false": - embed_var.add_field(name="❌ player.teleport-if-outside-border", - value="Enable this in purpur.yml.") - except KeyError: - unchecked = unchecked + 1 except ValueError: embed_var.add_field(name="❌ Invalid Configuration", value="At least one of your configuration files had an invalid data type.") diff --git a/cogs/timings_check.yml b/cogs/timings_check.yml index 93e303c..76e1c45 100644 --- a/cogs/timings_check.yml +++ b/cogs/timings_check.yml @@ -154,4 +154,298 @@ plugins: prefix: "⚠ " value: |- "You probably don't need VillagerLobotomizatornator as Purpur already adds its features. " - "Enable villager.lobotomize.enabled in purpur.yml." \ No newline at end of file + "Enable villager.lobotomize.enabled in purpur.yml." +config: + server.properties: + online-mode: + - expressions: + - not server_properties["online-mode"] + - spigot["settings"]["bungeecord"] == "false" + - paper["settings"]["velocity-support"]["online-mode"] == "false" or paper["settings"]["velocity-support"]["enabled"] == "false" + prefix: "❌ " + value: "Enable this in server.properties for security." + bukkit: + chunk-gc.period-in-ticks: + - expressions: + - int(bukkit["chunk-gc"]["period-in-ticks"]) >= 600 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 400." + ticks-per.monster-spawns: + - expressions: + - int(bukkit["ticks-per"]["monster-spawns"]) == 1 + prefix: "❌ " + value: "Increase this in bukkit.yml.\nRecommended: 4." + spawn-limits.monsters: + - expressions: + - int(bukkit["spawn-limits"]["monsters"]) >= 70 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 15." + spawn-limits.water-ambient: + - expressions: + - int(bukkit["spawn-limits"]["water-ambient"]) >= 20 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 2." + spawn-limits.ambient: + - expressions: + - int(bukkit["spawn-limits"]["ambient"]) >= 15 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 1." + spawn-limits.animals: + - expressions: + - int(bukkit["spawn-limits"]["animals"]) >= 10 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 3." + spawn-limits.water-animals: + - expressions: + - int(bukkit["spawn-limits"]["water-animals"]) >= 15 + prefix: "❌ " + value: "Decrease this in bukkit.yml.\nRecommended: 2." + spigot: + view-distance: + - expressions: + - server_properties["view-distance"] >= 10 + - spigot["world-settings"]["default"]["view-distance"] == "default" + prefix: "❌ " + value: |- + "Decrease this from default (10) in spigot.yml. " + "Recommended: 3." + entity-activation-range.animals: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["animals"]) >= 32 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 6." + entity-activation-range.monsters: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["monsters"]) >= 32 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 16." + entity-activation-range.misc: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["misc"]) >= 16 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 4." + entity-activation-range.water: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["water"]) >= 16 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 12." + entity-activation-range.villagers: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["villagers"]) >= 32 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 16." + entity-activation-range.tick-inactive-villagers: + - expressions: + - spigot["world-settings"]["default"]["entity-activation-range"]["tick-inactive-villagers"] == "true" + prefix: "❌ " + value: "Disable this in spigot.yml." + nerf-spawner-mobs: + - expressions: + - spigot["world-settings"]["default"]["nerf-spawner-mobs"] == "false" + prefix: "❌ " + value: "Enable this in spigot.yml." + entity-activation-range.wake-up-inactive.villagers-for: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["villagers-for"]) >= 100 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 20." + entity-activation-range.wake-up-inactive.flying-monsters-for: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["flying-monsters-for"]) >= 100 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 60." + entity-activation-range.wake-up-inactive.villagers-max-per-tick: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["villagers-max-per-tick"]) >= 4 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 1." + entity-activation-range.wake-up-inactive.animals-for: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["animals-for"]) >= 4 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 1." + entity-activation-range.wake-up-inactive.monsters-max-per-tick: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["monsters-max-per-tick"]) >= 8 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 4." + entity-activation-range.wake-up-inactive.flying-monsters-max-per-tick: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["flying-monsters-max-per-tick"]) >= 8 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 1." + entity-activation-range.wake-up-inactive.animals-max-per-tick: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["animals-max-per-tick"]) >= 4 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 2." + entity-activation-range.wake-up-inactive.monsters-for: + - expressions: + - int(spigot["world-settings"]["default"]["entity-activation-range"]["wake-up-inactive"]["monsters-for"]) >= 100 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 60." + arrow-despawn-rate: + - expressions: + - int(spigot["world-settings"]["default"]["arrow-despawn-rate"]) >= 1200 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 300." + merge-radius.item: + - expressions: + - float(spigot["world-settings"]["default"]["merge-radius"]["item"]) <= 2.5 + prefix: "❌ " + value: "Increase this in spigot.yml.\nRecommended: 4.0." + merge-radius.exp: + - expressions: + - float(spigot["world-settings"]["default"]["merge-radius"]["exp"]) <= 3.0 + prefix: "❌ " + value: "Increase this in spigot.yml.\nRecommended: 6.0." + max-entity-collisions: + - expressions: + - int(spigot["world-settings"]["default"]["merge-radius"]["exp"]) >= 8 + prefix: "❌ " + value: "Decrease this in spigot.yml.\nRecommended: 2." + paper: + max-auto-save-chunks-per-tick: + - expressions: + - int(paper["world-settings"]["default"]["max-auto-save-chunks-per-tick"]) >= 24 + prefix: "❌ " + value: "Decrease this in paper.yml.\nRecommended: 6." + optimize-explosions: + - expressions: + - paper["world-settings"]["default"]["optimize-explosions"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + mob-spawner-tick-rate: + - expressions: + - int(paper["world-settings"]["default"]["mob-spawner-tick-rate"]) == 1 + prefix: "❌ " + value: "Increase this in paper.yml.\nRecommended: 2." + game-mechanics.disable-chest-cat-detection: + - expressions: + - paper["world-settings"]["default"]["game-mechanics"]["disable-chest-cat-detection"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml" + container-update-tick-rate: + - expressions: + - paper["world-settings"]["default"]["game-mechanics"]["container-update-tick-rate"] == "false" + prefix: "❌ " + value: "Increase this in paper.yml.\nRecommended: 3." + grass-spread-tick-rate: + - expressions: + - int(paper["world-settings"]["default"]["game-mechanics"]["grass-spread-tick-rate"]) == 1 + prefix: "❌ " + value: "Increase this in paper.yml.\nRecommended: 4." + despawn-ranges.soft: + - expressions: + - int(paper["world-settings"]["default"]["despawn-ranges"]["soft"]) >= 32 + prefix: "❌ " + value: "Decrease this in paper.yml.\nRecommended: 28." + despawn-ranges.hard: + - expressions: + - int(paper["world-settings"]["default"]["despawn-ranges"]["hard"]) >= 32 + prefix: "❌ " + value: "Decrease this in paper.yml.\nRecommended: 48." + hopper.disable-move-event: + - expressions: + - paper["world-settings"]["default"]["hopper"]["disable-move-event"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml" + non-player-arrow-despawn-rate: + - expressions: + - int(paper["world-settings"]["default"]["non-player-arrow-despawn-rate"]) == -1 + prefix: "❌ " + value: "Set a value in paper.yml.\nRecommended: 60" + creative-arrow-despawn-rate: + - expressions: + - int(paper["world-settings"]["default"]["creative-arrow-despawn-rate"]) == -1 + prefix: "❌ " + value: "Set a value in paper.yml.\nRecommended: 60" + non-player-arrow-despawn-rate: + - expressions: + - paper["world-settings"]["default"]["prevent-moving-into-unloaded-chunks"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + use-faster-eigencraft-redstone: + - expressions: + - paper["world-settings"]["default"]["use-faster-eigencraft-redstone"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + fix-climbing-bypassing-cramming-rule: + - expressions: + - paper["world-settings"]["default"]["fix-climbing-bypassing-cramming-rule"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + armor-stands-do-collision-entity-lookups: + - expressions: + - paper["world-settings"]["default"]["armor-stands-do-collision-entity-lookups"] == "true" + prefix: "❌ " + value: "Disable this in paper.yml." + armor-stands-tick: + - expressions: + - paper["world-settings"]["default"]["armor-stands-tick"] == "true" + - '"PetBlocks" not in plugins' + - '"BlockBalls" not in plugins' + - '"ArmorStandTools" not in plugins' + prefix: "❌ " + value: "Disable this in paper.yml." + per-player-mob-spawns: + - expressions: + - paper["world-settings"]["default"]["per-player-mob-spawns"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + alt-item-despawn-rate.enabled: + - expressions: + - paper["world-settings"]["default"]["alt-item-despawn-rate"]["enabled"] == "false" + prefix: "❌ " + value: "Enable this in paper.yml." + enable-treasure-maps: + - expressions: + - paper["world-settings"]["default"]["enable-treasure-maps"] == "true" + prefix: "❌ " + value: "Disable this in paper.yml. Why? Generating treasure maps is extremely expensive and can hang a server if the structure it's trying to locate is really far away." + projectile-load-save-per-chunk-limit: + - expressions: + - int(paper["world-settings"]["default"]["projectile-load-save-per-chunk-limit"]) == -1 + prefix: "❌ " + value: "Set a value in paper.yml. Recommended: 8." + purpur: + settings.dont-send-useless-entity-packets: + - expressions: + - purpur["settings"]["dont-send-useless-entity-packets"] == "false" + prefix: "❌ " + value: "Enable this in purpur.yml." + mobs.dolphin.disable-treasure-searching: + - expressions: + - purpur["world-settings"]["default"]["mobs"]["dolphin"]["disable-treasure-searching"] == "false" + prefix: "❌ " + value: "Enable this in purpur.yml." + mobs.villager.brain-ticks: + - expressions: + - int(purpur["world-settings"]["default"]["mobs"]["villager"]["brain-ticks"]) == 1 + prefix: "❌ " + value: "Increase this in purpur.yml.\nRecommended: 4." + mobs.villager.spawn-iron-golem.radius: + - expressions: + - int(purpur["world-settings"]["default"]["mobs"]["villager"]["spawn-iron-golem"]["radius"]) == 0 + prefix: "❌ " + value: "Increase this in purpur.yml.\nRecommended: 5." + mobs.zombie.aggressive-towards-villager-when-lagging: + - expressions: + - purpur["world-settings"]["default"]["mobs"]["zombie"]["aggressive-towards-villager-when-lagging"] == "true" + prefix: "❌ " + value: "Disable this in purpur.yml." + gameplay-mechanics.entities-can-use-portals: + - expressions: + - purpur["world-settings"]["default"]["gameplay-mechanics"]["entities-can-use-portals"] == "true" + prefix: "❌ " + value: "Disable this in purpur.yml to prevent players from creating chunk anchors." + mobs.villager.lobotomize.enabled: + - expressions: + - purpur["world-settings"]["default"]["mobs"]["villager"]["lobotomize"]["enabled"] == "false" + prefix: "❌ " + value: "Enable this in purpur.yml." + gameplay-mechanics.player.teleport-if-outside-border: + - expressions: + - purpur["world-settings"]["default"]["gameplay-mechanics"]["player"]["teleport-if-outside-border"] == "false" + prefix: "❌ " + value: "Enable this in purpur.yml." \ No newline at end of file