stefatorus
/
LagAssist
5
5
Fork 14
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones

Fix console error spamming on Yatopia #2

Closed
minecraftplayer456 wants to merge 1 commits from minecraftplayer456/LagAssist:master into master
Conversation 1 Commits 1 Files Changed 1
minecraftplayer456 commented 4 years ago

The not thread-safe Bukkit-API was called async instead of sync with Yatopia minecraft server. This led the AsyncCatcher throwing an Exception every time the playoutspawnentity packet was send.

I changed the call so that the Bukkit-API is called sync.

Issue: #1

The not thread-safe Bukkit-API was called async instead of sync with Yatopia minecraft server. This led the AsyncCatcher throwing an Exception every time the playoutspawnentity packet was send. I changed the call so that the Bukkit-API is called sync. Issue: #1
minecraftplayer456 added 1 commit 4 years ago
stefatorus commented 3 years ago
Owner

Hi, sorry for the late response. Calling the method sync is not the solution as this will have to sync for all packets sent. When a large amount of entities are spawned, this will lead to significant performance issues and slow down the netty threads.

I've implemented a patch to now try to dissect the packet in later versions rather than unsafely call a sync method async. Hope this solves the issue.

Thank you for coming with the solution and diagnosing where the problem is from. If you didn't have a commercial license, I believe your contribution is worth receiving one.

Best Regards,
Stefan

Hi, sorry for the late response. Calling the method sync is not the solution as this will have to sync for all packets sent. When a large amount of entities are spawned, this will lead to significant performance issues and slow down the netty threads. I've implemented a patch to now try to dissect the packet in later versions rather than unsafely call a sync method async. Hope this solves the issue. Thank you for coming with the solution and diagnosing where the problem is from. If you didn't have a commercial license, I believe your contribution is worth receiving one. Best Regards, Stefan
stefatorus locked as Resolved and limited conversation to collaborators 3 years ago
stefatorus closed this pull request 3 years ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'minecraftplayer456/LagAssist:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes